Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moveElemsAttrsToGroups should not move transform if group has filter attribute #1933

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

johnkenny54
Copy link
Contributor

Closes #1752

As far as I can tell, this change has no effect on regression.js - same number of mismatches, identical total file compression.

Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR, and sorry for the delay. I was pretty busy last week.

The fix makes sense to me, but I'd like if we could simplify the test case before merging.

test/plugins/moveElemsAttrsToGroup.08.svg.txt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moveElemsAttrsToGroup breaks icon when transform and filter are present
2 participants